Closed
Conversation
StreamingBuffer is not required to find the intersecting regions, so, don't pass it as a param to the fn.
This reverts commit 2fb5059. Logic is incorrect, a shown by failing tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10288 +/- ##
===========================================
+ Coverage 73.31% 82.32% +9.01%
===========================================
Files 895 978 +83
Lines 148215 272029 +123814
===========================================
+ Hits 108666 223954 +115288
- Misses 39549 48075 +8526
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Jan 30, 2024
Member
jasonish
left a comment
jasonish
left a comment
There was a problem hiding this comment.
Looks OK. CI issue looks intermittent. Will restart when it gives me the option.
|
ERROR: ERROR: QA failed on SURI_TLPW2_autofp_suri_time. Pipeline 17942 |
Member
Author
|
revert commit rejected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#1624