next/276/70x/20240203/v1#10308
Merged
victorjulien merged 3 commits intoOISF:main-7.0.xfrom Feb 6, 2024
Merged
Conversation
When a TCP flow packet has not led to app-layer updates, it is useless to run DetectRunTx, as there cannot be new matches. This happens for instance, when one side sends in a row multiple packets which are not acked (and thus not parsed in IDS mode). Doing so requires to move up the call to AppLayerParserSetTransactionInspectId so that it is run the same times DetectRunTx is run, and not in the case where the transaction was not updated. Ticket: 6299 (cherry picked from commit 9240ae2)
Especially sets transactions to complete when we get a response without having seen the request, so that the transactions end up getting cleaned (instead of living/leaking in the state). Also try to set the event on the relevant transaction, instead of creating a new transaction just for the purpose of having the event. Ticket: OISF#6299 (cherry picked from commit 89936b6)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #10308 +/- ##
==============================================
+ Coverage 82.22% 82.29% +0.07%
==============================================
Files 975 975
Lines 274789 274776 -13
==============================================
+ Hits 225937 226131 +194
+ Misses 48852 48645 -207
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 18066 |
jufajardini
approved these changes
Feb 5, 2024
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Unless the QA lab warnings are cause of worry, this looks good to me.
Has all commits from the original PR (except the one that was skipped), nothing looks wrong.
jasonish
approved these changes
Feb 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging: