Closed
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10319 +/- ##
===========================================
+ Coverage 73.31% 82.36% +9.04%
===========================================
Files 895 966 +71
Lines 148215 271643 +123428
===========================================
+ Hits 108666 223730 +115064
- Misses 39549 47913 +8364
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline 18159 |
|
We've been reworking things but I'm assuming the QA job is accurate. Will check tomorrow. |
Contributor
Author
|
There is supposedly no changes to detection here. |
Contributor
Author
|
Replaced by #10370 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
#10300 with keeping the logging direction for each app-layer protocol
does not need SV PR