Closed
Conversation
Ticket: 3827
if no config option is found, as is done for udp Ticket: 6304
Including the one for websocket over HTTP/2
port is used in AppLayerProtoDetectProbingParserPort and not in AppLayerProtoDetectProbingParserElement
As for WebSocket which is detected only by protocol change.
When there is a protocol change, and a specific protocol is expected, like WebSeocket, always run it, no matter the port.
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
Closed
catenacyber
force-pushed
the
websockets-2695-v16
branch
from
43991c5 to
3affcaa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10375 +/- ##
==========================================
- Coverage 82.52% 82.44% -0.09%
==========================================
Files 978 971 -7
Lines 272148 272227 +79
==========================================
- Hits 224595 224434 -161
- Misses 47553 47793 +240
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This QA pipeline got stuck on the last job but looks normal (as far as anything does currently) aside from TLPR1
|
Closed
Contributor
Author
|
Rebased in #10409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2695
Describe changes:
OISF/suricata-verify#1571
#10176 with rebase on top of #10370 (and doc fix for websocket.opcode being 8-bit and 32-bit)