dns: add missing dns keywords to schema.json v6#10460
dns: add missing dns keywords to schema.json v6#10460hadiqaalamdar wants to merge 1 commit intoOISF:masterfrom
Conversation
Found and added missing dns fields in schema.json after manual code review. Added description to these newly added dns fields. Feature OISF#5642
| "type": "integer" | ||
| }, | ||
| "tc": { | ||
| "description": "A 1-bit subfield for truncated response that specifies if the length of the message exceeds the allowed length", |
There was a problem hiding this comment.
I'd like others' opinions on this but I think this looks very RFC definition and not very Suricata specific like what does this field in Suricata logs represent. Like DNS truncated response field as a boolean..
Note that this is not a change requested. Would like your and other opinions on this.
There was a problem hiding this comment.
I do not think there is a difference for this field between RFC and Suricata...
If I want to be nitpicky, I would say 1-bit subfield is redundant
There was a problem hiding this comment.
Is your question towards description style? If so, I understand what you say.
Have we ever discussed what we'd like these descriptions to look like? Any style guide or something?
There was a problem hiding this comment.
I think it should be pretty simple, perhaps along the lines of:
DNS truncation flag.
We shouldn't actually say that this means the DNS truncation message was truncated. Its easy to set this value to true or false whether the actual DNS message was truncated or not. So this should just describe what that header value was set to.
|
New PR: #10476 |
5 participants
Feature #5642
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5642
Previous PR: #10432
Describe changes:
SV_BRANCH=OISF/suricata-verify#1588