mqtt: Improve frame parsing w/mult. PDUs backport7#10489
Merged
victorjulien merged 1 commit intoOISF:main-7.0.xfrom Feb 27, 2024
Merged
mqtt: Improve frame parsing w/mult. PDUs backport7#10489victorjulien merged 1 commit intoOISF:main-7.0.xfrom
victorjulien merged 1 commit intoOISF:main-7.0.xfrom
Conversation
This commit improves the mqtt parsing of frames to handle multiple PDUs. Issue: 6592 (cherry picked from commit f9a20da)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #10489 +/- ##
==============================================
- Coverage 82.52% 82.50% -0.02%
==============================================
Files 976 976
Lines 275048 275048
==============================================
- Hits 226982 226935 -47
- Misses 48066 48113 +47
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 18694 |
jlucovsky
approved these changes
Feb 23, 2024
victorjulien
approved these changes
Feb 24, 2024
Member
|
Merged in #10508, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6593
Describe changes:
OISF/suricata-verify#1665