Closed
Conversation
This gives app layer code a chance to access feature information.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10579 +/- ##
==========================================
- Coverage 82.67% 82.62% -0.05%
==========================================
Files 922 927 +5
Lines 246969 247803 +834
==========================================
+ Hits 204179 204753 +574
- Misses 42790 43050 +260
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
Added back the ticket reference in the commit message. |
catenacyber
reviewed
Mar 12, 2024
catenacyber
reviewed
Mar 12, 2024
catenacyber
requested changes
Mar 12, 2024
Contributor
catenacyber
left a comment
There was a problem hiding this comment.
Thanks for the work Sascha :-)
- CI : needs a rebase to fix the small conflict
- Code : doing now
- Commits segmentation : nice
- Commit messages : ok for me
- Git ID set : looks fine for me
- CLA : you already contributed :-)
- Doc update : Ok
- Redmine ticket : ok
- Rustfmt : ok for ja4.rs
- Tests : Left remarks there
- Dependencies added: none
catenacyber
reviewed
Mar 12, 2024
catenacyber
reviewed
Mar 12, 2024
catenacyber
reviewed
Mar 12, 2024
catenacyber
reviewed
Mar 12, 2024
Contributor
|
Compiling with |
Contributor
Author
True, I just addressed this and also double-checked that for JA3. |
Contributor
Author
|
New PR: #10725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR: #10341
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379
Changes to previous PR:
ja4.ciphersuites.len()instead of separate counter.#definecarried over from older code.JA4_HEX_LENinto separate header to be used in detect and output code.