Skip to content

Comments

Dns over http2 5773 v9#10984

Closed
catenacyber wants to merge 10 commits intoOISF:masterfrom
catenacyber:dns-over-http2-5773-v9
Closed

Dns over http2 5773 v9#10984
catenacyber wants to merge 10 commits intoOISF:masterfrom
catenacyber:dns-over-http2-5773-v9

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5773

Describe changes:

  • analyze DNS over HTTP2

SV_BRANCH=OISF/suricata-verify#1734

Draft to get feedback about approach...

#10898 with needed rebase after recent dns and http2 merges

TODO :

Functionnaly, in terms of output :

  • The flow will have doh2 as app_proto (and http2 as app_proto_orig)
  • There are doh2 events that have both http2 and dns fields. dns logging is done like alerts, not like dns events...
  • DNS and HTTP and HTTP2 signatures work on DOH2
  • Signatures can be DOH2 specific. These signatures can combine http, http2 and dns keywords.
  • DNS Frames do not work on DoH2

Memory management

  • a HTTP2 tx can own 2 DNS tx (one to client, one to server)
  • a HTTP2 tx stores the streamed DNS response content until it is complete before parsing it (limiting to U16_MAX bytes)

API

  • There is a new DOH2 app-layer protocol which resorts to HTTP2 for most of the things
  • HTTP2 parsing discovering DOH2 changes the app_proto to DOH2, doh2 can be enabled or disabled in suricata.yaml config
  • There are more alproto "comparison" functions
  • Every DNS keyword needs to check the flow alproto to change the transaction
  • Every DNS/HTTP keyword is automatically registered for DOH2 (hacking DetectAppLayerMpmRegister2...

by making tx parsing and creation more easily available,
without needing a dns state.

Dns event NotResponse is now set on the right tx, and not the one
before.

Also debug log for Z-flag on request says "request" instead of
"response"

Also rustfmt dns.rs
Now a flow alproto can be changed by a call to AppLayerParserParse
when HTTP2 forces the flow to turn into DOH2.
Ticket: 5773

Handles both directions the same way for data if content type is
application/dns-message
@codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 89.66480% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 82.92%. Comparing base (df8568e) to head (e9cbd4a).
Report is 115 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10984      +/-   ##
==========================================
- Coverage   83.03%   82.92%   -0.11%     
==========================================
  Files         917      917              
  Lines      248684   248907     +223     
==========================================
- Hits       206489   206405      -84     
- Misses      42195    42502     +307     
Flag Coverage Δ
fuzzcorpus 64.29% <67.59%> (-0.08%) ⬇️
suricata-verify 62.19% <82.12%> (-0.51%) ⬇️
unittests 62.28% <33.24%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

field baseline test %
SURI_TLPR1_stats_chk
.memcap.pressure 57 53 92.98%
.memcap.pressure_max 62 65 104.84%

Pipeline 20408

@catenacyber catenacyber added the needs rebase Needs rebase to main label May 31, 2024
@catenacyber
Copy link
Contributor Author

Rebased in #11196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs rebase Needs rebase to main

Development

Successfully merging this pull request may close these issues.

2 participants