Skip to content

Comments

next/433/20240505/v1#11023

Merged
victorjulien merged 2 commits intoOISF:masterfrom
victorjulien:next/433/20240505/v1
May 6, 2024
Merged

next/433/20240505/v1#11023
victorjulien merged 2 commits intoOISF:masterfrom
victorjulien:next/433/20240505/v1

Conversation

@victorjulien
Copy link
Member

dependabot bot and others added 2 commits May 5, 2024 08:32
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@5d5d22a...6546280)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Ticket: 3725

This test was moved to suricata-verify snmp-community
@victorjulien victorjulien requested a review from jasonish as a code owner May 5, 2024 09:22
@codecov
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (f14a4a1) to head (ce4119a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11023      +/-   ##
==========================================
+ Coverage   80.66%   83.62%   +2.96%     
==========================================
  Files         923      922       -1     
  Lines      250204   250321     +117     
==========================================
+ Hits       201833   209340    +7507     
+ Misses      48371    40981    -7390     
Flag Coverage Δ
fuzzcorpus 64.22% <100.00%> (-0.09%) ⬇️
livemode 18.42% <100.00%> (-0.01%) ⬇️
suricata-verify 62.75% <100.00%> (?)
unittests 62.26% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20507

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien merged commit ce4119a into OISF:master May 6, 2024
@victorjulien victorjulien deleted the next/433/20240505/v1 branch May 6, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants