Closed
Conversation
inashivb
force-pushed
the
dataset-string-memcap-3910/v5
branch
from
a1ad5c5 to
27bff45
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11105 +/- ##
===========================================
- Coverage 84.09% 75.18% -8.92%
===========================================
Files 925 852 -73
Lines 250594 137097 -113497
===========================================
- Hits 210733 103071 -107662
+ Misses 39861 34026 -5835
Flags with carried forward coverage won't be shown. Click here to find out more. |
In order to have access to the length of datatypes with variable lengths to correctly update memuse to calculate memcaps. Bug 3910
So far, when the data size was passed to the THash API, it was sent as a sizeof(Struct) which works fine for the other data types as they have a fixed length but not for the StringType. However, because of the sizeof construct, the length of a string type dataset was always taken to be 16 Bytes which is only the size of the struct itself. It did not accomodate the actual size of the string that the StringType holds. Fix this so that the memuse that is used to determine whether memcap was reached also takes into consideration the size of the actual string. Bug 3910
Add a callback and helper function to handle data expiration. Update datasets to explicitly not use expiration.
inashivb
force-pushed
the
dataset-string-memcap-3910/v5
branch
from
27bff45 to
03a00a1
Compare
|
Information: QA ran without warnings. Pipeline 20713 |
jufajardini
reviewed
May 22, 2024
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Have a suggestion for the upgrading doc.
The other two questions are more out of curiosity, to learn more...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/3910
Previous PR: #11104
Changes since v4: