Conversation
|
Coming from #3806 !!! |
| } | ||
|
|
||
| #[no_mangle] | ||
| pub unsafe extern "C" fn rs_validate_domain(input: *const u8, in_len: u32) -> u32 { |
There was a problem hiding this comment.
I think this supposed to use a different naming style now, right @jasonish?
There was a problem hiding this comment.
Correct, changing
| // or if client side is unknown despite having received bytes | ||
| r = ALPROTO_FTP; | ||
| } | ||
| for (uint32_t i = 4; i < len; i++) { |
There was a problem hiding this comment.
maybe better to use memchr for this? Can have optimized implementations.
There was a problem hiding this comment.
probably out of scope for this PR, but there is a rust memchr crate that claims some pretty good performance too IIRC
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11125 +/- ##
==========================================
+ Coverage 84.10% 84.15% +0.05%
==========================================
Files 926 926
Lines 250712 247478 -3234
==========================================
- Hits 210858 208271 -2587
+ Misses 39854 39207 -647
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
qa tokens ran out. ignore the 'pipeline canceled' incoming |
|
Continued in #11128 |
3 participants
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/1125
Describe changes:
SV_BRANCH=OISF/suricata-verify#1850
Follow up on #8892 after merge of #10982