Skip to content

Smtp server detection 1125 v2.3#11261

Closed
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:smtp-server-detection-1125-v2.3
Closed

Smtp server detection 1125 v2.3#11261
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:smtp-server-detection-1125-v2.3

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/1125
https://redmine.openinfosecfoundation.org/issues/6821
https://redmine.openinfosecfoundation.org/issues/5491

Describe changes:

  • smtp server detection (ie to_client)
  • ftp server detection (ie to_client)
  • smtp recognize more reply codes

SV_BRANCH=OISF/suricata-verify#1894

#11193 rebased with increased SV tests

@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 85.39326% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (358bc05) to head (d089e99).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11261      +/-   ##
==========================================
+ Coverage   79.68%   83.01%   +3.32%     
==========================================
  Files         942      942              
  Lines      249186   249433     +247     
==========================================
+ Hits       198566   207057    +8491     
+ Misses      50620    42376    -8244     
Flag Coverage Δ
fuzzcorpus 61.12% <82.66%> (+0.01%) ⬆️
livemode 18.79% <16.00%> (-0.01%) ⬇️
pcap 44.36% <80.00%> (+0.04%) ⬆️
suricata-verify 61.71% <80.00%> (?)
unittests 60.50% <48.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber catenacyber added the needs baseline update QA will need a new base line label Jun 6, 2024
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW1_stats_chk
.app_layer.flow.smtp 7556 7827 103.59%
.app_layer.error.smtp.parser 409 42 10.27%
SURI_TLPR1_stats_chk
.app_layer.flow.smtp 335817 347671 103.53%
.app_layer.flow.failed_tcp 178240 161748 90.75%
.app_layer.tx.ftp 101030 95193 94.22%
.app_layer.error.smtp.parser 527 177 33.59%
.ftp.memuse 10637 2906 27.32%

Pipeline 21000

@catenacyber
Copy link
Contributor Author

@ct0br0 could I get now an extract of TLPR of flows + tx + memos that are in master but no longer in this PR ?

@catenacyber
Copy link
Contributor Author

Continued in #11314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs baseline update QA will need a new base line

Development

Successfully merging this pull request may close these issues.

2 participants