Closed
Conversation
Ticket: 5734 Adds frames for SSH records, that come after banner, and before the data is encrypted. These records may contain cipher lists for instance.
for SSH packets that mark the end of plaintext
use debug_validate_bug_on instead
Used by documentation with the SIP frames only
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11451 +/- ##
==========================================
+ Coverage 82.44% 82.50% +0.05%
==========================================
Files 938 938
Lines 248068 248122 +54
==========================================
+ Hits 204513 204705 +192
+ Misses 43555 43417 -138
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
reviewed
Jul 9, 2024
|
|
||
| * ssh.record_hdr | ||
| * ssh.record_data | ||
| * ssh.record_pdu |
Member
There was a problem hiding this comment.
Can this get some more explanation and some examples too perhaps?
Contributor
Author
There was a problem hiding this comment.
Trying something
Closed
Contributor
Author
|
Continues in #11475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5734
Describe changes:
panicin packet pathSV_BRANCH=OISF/suricata-verify#1932
#11415 with commit removing wrong comments