detect/integers: harmonize parser return handling (backport7)#11514
Closed
catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
Closed
detect/integers: harmonize parser return handling (backport7)#11514catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
Conversation
Ticket: 7172 When parsing an integer for a rule keyword fails, we return error straight away, without bothering to try to free the NULL pointer. On the way, remove some one-line wrapper around DetectUxParse (cherry picked from commit daad7f2)
|
Information: QA ran without warnings. Pipeline 21578 |
victorjulien
approved these changes
Jul 29, 2024
Member
|
Merged in #11613, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7173
Describe changes:
Conflicts easy to fix manually