Merged
Conversation
Ticket: OISF#2886 Signed-off-by: mmaatuq <mahmoudmatook.mm@gmail.com>
Ticket: 6821
This implementation adds types and filters specified in the LDAP RFC to work with the ldap_parser. Although using the parser directly would be best, strange behavior has been observed during transaction logging. It appears that C pointers are being overwritten, leading to incorrect output when LDAP fields are logged.
victorjulien
requested review from
a team,
jasonish and
jufajardini
as code owners
|
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11515 +/- ##
==========================================
- Coverage 82.66% 82.54% -0.12%
==========================================
Files 918 923 +5
Lines 247447 248460 +1013
==========================================
+ Hits 204543 205083 +540
- Misses 42904 43377 +473
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 21584 |
lukashino
approved these changes
Jul 18, 2024
This was referenced Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#1982
Staging: