Closed
Conversation
When configure is used with --enable-warnings, we try to add most warning flags that should pass. This commits adds the warning Wimplicit-int-float-conversion
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11519 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 918 918
Lines 247447 247486 +39
=======================================
+ Hits 204543 204595 +52
+ Misses 42904 42891 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21597 |
victorjulien
requested changes
Jul 18, 2024
| } | ||
| } | ||
|
|
||
| static bool json_u32_value(json_t *jarg, uint32_t *ret) |
Contributor
Author
There was a problem hiding this comment.
changing it to JsonU32Value, I was imitating json_integer_value style
| } | ||
| bpf_len = st.st_size + 1; | ||
| if ((uint64_t)st.st_size > UINT32_MAX - 1) { | ||
| SCLogError("Too big file %s", filename); |
Member
There was a problem hiding this comment.
think this reads a bit oddly
Contributor
Author
There was a problem hiding this comment.
removing this commit for now
Contributor
Author
|
Continued in #11524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32warnings for some files : defrag, datasets, suricata.c, runmodes-Wimplicit-int-float-conversionto the set of warning flags used by./configure --enable-warningsSome commits of #9840
#11453 next batch
#11517 final version getting green CI with clean git history
Still to do afterwards :