Merged
Conversation
Ticket: 5734 Adds frames for SSH records, that come after banner, and before the data is encrypted. These records may contain cipher lists for instance.
for SSH packets that mark the end of plaintext
use debug_validate_bug_on instead
Used by documentation with the SIP frames only
Ticket: 5053
Ticket: 5053
Ticket: 5053
Ticket: 7181 Allows confyaml.c to be in the release archive
warning: can be more succinctly written as a byte str
--> src/mime/smtp.rs:762:37
|
762 | mime_smtp_find_url_strings(ctx, &[b'\n']);
| ^^^^^^^^ help: try: `b"\n"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices
= note: `#[warn(clippy::byte_char_slices)]` on by default
warning: this `match` can be collapsed into the outer `match` help: the outer pattern can be modified to include the inner pattern
victorjulien
requested review from
catenacyber,
jasonish and
jufajardini
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11595 +/- ##
==========================================
+ Coverage 82.50% 82.52% +0.01%
==========================================
Files 923 923
Lines 248721 248808 +87
==========================================
+ Hits 205215 205317 +102
+ Misses 43506 43491 -15
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21808 |
jufajardini
approved these changes
Aug 1, 2024
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Number of commits, lines added and removed match. ✔️
This was referenced Aug 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#1998