Skip to content

Comments

Warnint 64to32 6186 v23.4#11952

Closed
catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber:warnint-64to32-6186-v23.4
Closed

Warnint 64to32 6186 v23.4#11952
catenacyber wants to merge 2 commits intoOISF:masterfrom
catenacyber:warnint-64to32-6186-v23.4

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186

Describe changes:

  • fix -Wshorten-64-to-32 warnings for some files : output, stream

Some commits of #9840
#11580 next batch
#11904 without commit about https://redmine.openinfosecfoundation.org/issues/7311 (and so still some warning)

Still to do afterwards :

  • detect
  • util

@codecov
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.73%. Comparing base (15c4eb3) to head (f9bbba8).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11952      +/-   ##
==========================================
- Coverage   82.74%   82.73%   -0.02%     
==========================================
  Files         910      910              
  Lines      249008   249003       -5     
==========================================
- Hits       206043   206005      -38     
- Misses      42965    42998      +33     
Flag Coverage Δ
fuzzcorpus 60.78% <78.12%> (+0.01%) ⬆️
livemode 18.70% <7.81%> (+<0.01%) ⬆️
pcap 44.09% <54.68%> (+<0.01%) ⬆️
suricata-verify 62.17% <82.81%> (-0.02%) ⬇️
unittests 59.01% <14.06%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23098

@victorjulien victorjulien added this to the 8.0 milestone Oct 14, 2024
@victorjulien
Copy link
Member

Merged in #11958, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants