Skip to content

fuzz/detect: forbid rule with pcre only on stream#11953

Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:detect-pcre-stream-warning-4858-v2
Closed

fuzz/detect: forbid rule with pcre only on stream#11953
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:detect-pcre-stream-warning-4858-v2

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/4858

Describe changes:

  • fuzz/detect: forbid rule with pcre only on stream

So as to avoid oss-fuzz timing out using a known to be bad rule

#11878 with change restricted to fuzzing as engine analysis already has the warning

to avoid fuzzing blocks on timeouts with known bad rules

Ticket: 4858
@codecov
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.74%. Comparing base (15c4eb3) to head (29d01fc).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11953      +/-   ##
==========================================
- Coverage   82.74%   82.74%   -0.01%     
==========================================
  Files         910      910              
  Lines      249008   249020      +12     
==========================================
  Hits       206043   206043              
- Misses      42965    42977      +12     
Flag Coverage Δ
fuzzcorpus 60.71% <100.00%> (-0.05%) ⬇️
livemode 18.70% <ø> (+<0.01%) ⬆️
pcap 43.94% <ø> (-0.16%) ⬇️
suricata-verify 62.18% <ø> (-0.02%) ⬇️
unittests 59.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23099

@victorjulien victorjulien added this to the 8.0 milestone Oct 14, 2024
@victorjulien
Copy link
Member

Merged in #11958, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants