detect/analyzer: add more details for the tcp window keyword-v1#12021
Closed
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Closed
detect/analyzer: add more details for the tcp window keyword-v1#12021Nancyenos wants to merge 1 commit intoOISF:masterfrom
Nancyenos wants to merge 1 commit intoOISF:masterfrom
Conversation
jufajardini
requested changes
Oct 23, 2024
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
This looks like the right approach to me, too :)
One minor change needed (a typo), please see inline comment.
The rules you've shared for the test candidates look good to me, maybe we could have one of them use tcp.window, instead of window, just to showcase that both work.
| const DetectWindowData *wd = (const DetectWindowData *)smd->ctx; | ||
| jb_open_object(js, "window"); | ||
| jb_set_uint(js, "size", wd->size); | ||
| jb_set_bool(js, "negate", wd->negated); |
Contributor
There was a problem hiding this comment.
Suggested change
| jb_set_bool(js, "negate", wd->negated); | |
| jb_set_bool(js, "negated", wd->negated); |
|
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12021 +/- ##
==========================================
+ Coverage 83.22% 83.25% +0.03%
==========================================
Files 910 910
Lines 258136 258143 +7
==========================================
+ Hits 214831 214924 +93
+ Misses 43305 43219 -86
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
Thankyou so much for the help @jufajardini |
Contributor
|
Work continued with #12024 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: 6352
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6352
Describe changes:
-detect/analyzer: add more details for the tcp window keyword
-I need help with this, am I in the right direction?
-Also am thinking of below tests and would like to know if i need to add more, i tested for exact and negated size
=