Skip to content

Applayer plugin 5053 v3.8#12060

Closed
catenacyber wants to merge 7 commits intoOISF:masterfrom
catenacyber:applayer-plugin-5053-v3.8
Closed

Applayer plugin 5053 v3.8#12060
catenacyber wants to merge 7 commits intoOISF:masterfrom
catenacyber:applayer-plugin-5053-v3.8

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • get ready to use dynamic number of app-layer protos (also work with static constant) in some places
  • preventive fix of macro with parenthesis cc @jufajardini

#12052 with Windows fix and fuzz fix and clean history

Example plugin at https://github.com/catenacyber/suricata-zabbix

instead of a global variable.

For easier initialization with dynamic number of protocols
for expectation_proto

Ticket: 5053
so that we can use safely EXCEPTION_POLICY_MAX*sizeof(x)
Ticket: 5053

delay after initialization so that StringToAppProto works
@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 74.43182% with 90 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (3a7eef8) to head (6b8fc8f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12060      +/-   ##
==========================================
- Coverage   83.42%   83.28%   -0.14%     
==========================================
  Files         910      910              
  Lines      257642   257757     +115     
==========================================
- Hits       214949   214685     -264     
- Misses      42693    43072     +379     
Flag Coverage Δ
fuzzcorpus 61.06% <68.01%> (-0.59%) ⬇️
livemode 19.42% <57.92%> (+0.01%) ⬆️
pcap 44.49% <70.02%> (+<0.01%) ⬆️
suricata-verify 62.76% <74.06%> (+<0.01%) ⬆️
unittests 59.35% <57.67%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber
Copy link
Contributor Author

Argh, there is some accidental improvement of a fuzz target that finds more edge cases and triggers assertions...

@catenacyber catenacyber force-pushed the applayer-plugin-5053-v3.8 branch from 489dd24 to 6b8fc8f Compare October 29, 2024 21:29
@catenacyber catenacyber marked this pull request as draft October 29, 2024 21:30
@catenacyber
Copy link
Contributor Author

Draft to check CI fuzzing status

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23208

@catenacyber
Copy link
Contributor Author

DEBIAN12 MSRV got ipv6-dos-with-ext-headers-6: FAILED: got exit code -11, expected 0 stderr is empty and stdout looks normal ending with Notice: pcap: read 1 file, 39838 packets, 3347446 bytes [ReceivePcapFileThreadExitStats:source-pcap-file.c:413]

@catenacyber catenacyber force-pushed the applayer-plugin-5053-v3.8 branch from 6b8fc8f to 2545897 Compare October 30, 2024 13:59
@catenacyber
Copy link
Contributor Author

So, let's git bisect the problem found by one CI runner in one SV test which looks unrelated...

@catenacyber
Copy link
Contributor Author

Maybe because Debian12 runs with profiling... and #11987 had green CI

@catenacyber
Copy link
Contributor Author

Next in #12066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants