eve: threadinit/deinit callbacks are optional for filetypes#12069
Closed
jasonish wants to merge 1 commit intoOISF:masterfrom
Closed
eve: threadinit/deinit callbacks are optional for filetypes#12069jasonish wants to merge 1 commit intoOISF:masterfrom
jasonish wants to merge 1 commit intoOISF:masterfrom
Conversation
Only call ThreadInit and ThreadDeinit for custom eve filetypes if they exist. They are not required by all filetypes. Ticket: OISF#7359
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12069 +/- ##
==========================================
- Coverage 83.42% 83.41% -0.02%
==========================================
Files 910 910
Lines 257642 257643 +1
==========================================
- Hits 214949 214915 -34
- Misses 42693 42728 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23224 |
victorjulien
approved these changes
Oct 31, 2024
Merged
Member
|
Merged in #12074, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only call ThreadInit and ThreadDeinit for custom eve filetypes if they
exist. They are not required by all filetypes.
Ticket: https://redmine.openinfosecfoundation.org/issues/7359