engine events: fix event names in rules or enum - v1#12075
Closed
jasonish wants to merge 4 commits intoOISF:masterfrom
Closed
engine events: fix event names in rules or enum - v1#12075jasonish wants to merge 4 commits intoOISF:masterfrom
jasonish wants to merge 4 commits intoOISF:masterfrom
Conversation
- not_a_request to not_request - not_a_response to not_reponse Ticket: OISF#7361
- weak_crypto_nodh -> weak_crypto_no_dh - weak_crypto_noauth -> weak_crypto_no_auth Ticket: OISF#7361
The event "modbus.invalid_unit_identifier" no longer exists. Ticket: OISF#7361
Rename InvalidHTTP1Settings to InvalidHttp1Settings so it gets the expected name transformation of "invalid_http1_settings". Ticket: OISF#7361
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12075 +/- ##
==========================================
- Coverage 83.42% 83.40% -0.03%
==========================================
Files 910 910
Lines 257642 257642
==========================================
- Hits 214949 214874 -75
- Misses 42693 42768 +75
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
reviewed
Nov 1, 2024
| alert dns any any -> any any (msg:"SURICATA DNS malformed response data"; flow:to_client; app-layer-event:dns.malformed_data; classtype:protocol-command-decode; sid:2240003; rev:2;) | ||
| # Response flag set on to_server packet | ||
| alert dns any any -> any any (msg:"SURICATA DNS Not a request"; flow:to_server; app-layer-event:dns.not_a_request; classtype:protocol-command-decode; sid:2240004; rev:2;) | ||
| alert dns any any -> any any (msg:"SURICATA DNS Not a request"; flow:to_server; app-layer-event:dns.not_request; classtype:protocol-command-decode; sid:2240004; rev:2;) |
Member
There was a problem hiding this comment.
any rule that is updated should have its rev bumped
Member
Author
|
Replaced by #12079. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes these warnings when using engine events:
Ticket: https://redmine.openinfosecfoundation.org/issues/7361