detect/http: fix progress for headers keywords (backport7)#12097
Closed
catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
Closed
detect/http: fix progress for headers keywords (backport7)#12097catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
Conversation
Ticket: 7326 Having a lower progress than one where we actually can get occurences of the multibuffer made prefilter bail out too early, not having found a buffer in the multi-buffer that matiched the prefilter. For example, we registered http_request_header with progress 0 instad of progress HTP_REQUEST_HEADERS==2, and if the first packet had only the request line, we would consider that signatures with http_request_header as prefilter/fast_pattern could not match for this transaction, even if they in fact could have a later packet with matching headers. Hence, we got false negatives, if http.request_header or http.response_header was used as fast pattern, and if the request or response came in multiple packets, and the first of these packets did not have enough data (like only http request line), and the next packets did have the matching data. (cherry picked from commit cca59cd)
victorjulien
approved these changes
Nov 7, 2024
Contributor
Author
|
do we need to backport some CI netmap caching commit ? |
|
Information: QA ran without warnings. Pipeline 23292 |
Member
|
Merged in #12106, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7327
Describe changes:
DetectAppLayerMultiRegisterwas introduced in 8 to simplify theseSV_BRANCH=OISF/suricata-verify#2122