7.0.x: fix engine event names; detect error when not found - v1#12099
Closed
jasonish wants to merge 5 commits intoOISF:main-7.0.xfrom
Closed
7.0.x: fix engine event names; detect error when not found - v1#12099jasonish wants to merge 5 commits intoOISF:main-7.0.xfrom
jasonish wants to merge 5 commits intoOISF:main-7.0.xfrom
Conversation
The returned event_id was being set to -1, but the function wasn't returning -1 to indicate error. Ticket: OISF#7361
victorjulien
approved these changes
Nov 7, 2024
|
Information: QA ran without warnings. Pipeline 23286 |
Member
|
Merged in #12106, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12079:
Ticket: Ticket: https://redmine.openinfosecfoundation.org/issues/7361