output/http: log invalid status as a string#12128
output/http: log invalid status as a string#12128catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
Ticket: 7311 If response_status_number is not a valid poisitive integer, we should not try to parse it again, and fail again, but just log the raw string.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12128 +/- ##
===========================================
+ Coverage 62.68% 83.11% +20.43%
===========================================
Files 840 909 +69
Lines 153669 257879 +104210
===========================================
+ Hits 96323 214343 +118020
+ Misses 57346 43536 -13810
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23422 |
| "status": { | ||
| "type": "integer" | ||
| }, | ||
| "status_str": { |
There was a problem hiding this comment.
We have no occurrences of _str, but do have one as _string, so maybe we should stick with that.
Also, please add a description. I wonder if that description should also include the rule keyword for matching? Or if not applicable, even state that somehow?
There was a problem hiding this comment.
guess a http.stat_code.raw? or http.stat.raw
There was a problem hiding this comment.
I guess I will go with status_string instead of opening a new json object
|
Next in #12164 |
4 participants
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7311
Describe changes:
Also fix integer warning on the way
SV_BRANCH=OISF/suricata-verify#2085
From #11904 in its own PR