Merged
Conversation
Threads are initialized sequentially to allow for a predictable mapping of threads and queues. Not all parts of the start up need to be done sequentially. The setting up of the rings can be very expensive, taking of a couple of hundred milliseconds. The ring setup doesn't need to be done sequentially though. This patch releases the thread early, after bind but before the ring setups. Ticket: OISF#7272.
Ticket: 7311 If response_status_number is not a valid poisitive integer, we should not try to parse it again, and fail again, but just log the raw string.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12222 +/- ##
==========================================
+ Coverage 83.18% 83.19% +0.01%
==========================================
Files 912 912
Lines 257169 257166 -3
==========================================
+ Hits 213914 213938 +24
+ Misses 43255 43228 -27
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Dec 4, 2024
|
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 23672 |
|
Information: QA ran without warnings. Pipeline 23681 |
This was referenced Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2161