detect: don't run pkt sigs on ffr pkts#12258
Closed
victorjulien wants to merge 1 commit intoOISF:masterfrom
Closed
detect: don't run pkt sigs on ffr pkts#12258victorjulien wants to merge 1 commit intoOISF:masterfrom
victorjulien wants to merge 1 commit intoOISF:masterfrom
Conversation
Last packet from the TLS TCP session moves TCP state to CLOSED.
This flags the app-layer with APP_LAYER_PARSER_EOF_TS or
APP_LAYER_PARSER_EOF_TC depending on the direction of the final packet.
This flag will just have been set in a single direction.
This leads to the last packet updating the inspect id in that packets
direction.
At the end of the TLS session a pseudo packet is created, because:
- flow has ended
- inspected tx id == 0, for at least one direction
- total txs is 1
Then a packet rule matches:
```
alert tcp any any -> any 443 (flow: to_server; \
flowbits:isset,tls_error; \
sid:09901033; rev:1; \
msg:"Allow TLS error handling (outgoing packet)"; )
```
The `SIG_MASK_REQUIRE_REAL_PKT` is not preventing the match, as the
`flowbits` keyword doesn't set it.
To avoid this match. This patch skips signatures of the `SIG_TYPE_PKT`
for flow end packets.
Ticket: OISF#7318.
This was referenced Dec 10, 2024
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12258 +/- ##
=======================================
Coverage 83.21% 83.22%
=======================================
Files 912 912
Lines 257183 257185 +2
=======================================
+ Hits 214025 214037 +12
+ Misses 43158 43148 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
catenacyber
approved these changes
Dec 10, 2024
Contributor
catenacyber
left a comment
catenacyber
left a comment
There was a problem hiding this comment.
Same as #12257 ok for me
|
WARNING:
Pipeline 23772 |
jasonish
approved these changes
Dec 10, 2024
Merged
Member
Author
|
Merged in #12259 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last packet from the TLS TCP session moves TCP state to CLOSED.
This flags the app-layer with APP_LAYER_PARSER_EOF_TS or APP_LAYER_PARSER_EOF_TC depending on the direction of the final packet. This flag will just have been set in a single direction.
This leads to the last packet updating the inspect id in that packets direction.
At the end of the TLS session a pseudo packet is created, because:
Then a packet rule matches:
The
SIG_MASK_REQUIRE_REAL_PKTis not preventing the match, as theflowbitskeyword doesn't set it.To avoid this match. This patch skips signatures of the
SIG_TYPE_PKTfor flow end packets.Ticket: #7318.
SV_BRANCH=OISF/suricata-verify#2174