app-layer: track modified/processed txs (backport7)#12293
Closed
catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
Closed
app-layer: track modified/processed txs (backport7)#12293catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
catenacyber wants to merge 1 commit intoOISF:main-7.0.xfrom
Conversation
To optimize detection, and logging, to avoid going through all the live transactions when only a few were modified. Two boolean fields are added to the tx data: updated_tc and ts The app-layer parsers are now responsible to set these when needed, and the logging and detection uses them to skip transactions that were not updated. There may some more optimization remaining by when we set both updated_tc and updated_ts in functions returning a mutable transaction, by checking if all the callers are called in one direction only (request or response) Ticket: 7087 (cherry picked from commit b02557a) Conflicts: rust/src/applayer.rs rust/src/enip/enip.rs rust/src/ldap/ldap.rs src/app-layer-smtp.c
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12293 +/- ##
==============================================
+ Coverage 83.21% 83.33% +0.11%
==============================================
Files 922 922
Lines 261173 261276 +103
==============================================
+ Hits 217338 217723 +385
+ Misses 43835 43553 -282
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
CI failure is tcp-urgp-07-oob-exceed-limit |
|
Information: QA ran without warnings. Pipeline 23985 |
Contributor
|
Is it a good time to merge this now? |
victorjulien
approved these changes
Feb 10, 2025
inashivb
requested changes
Feb 11, 2025
Member
inashivb
left a comment
inashivb
left a comment
There was a problem hiding this comment.
Commit message needs to be reworked so this can be staged again.
See: #12549 (comment)
Contributor
Author
|
Replaced by #12592 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7087
Describe changes:
Not a clean cherry-pick
Conflicts:
rust/src/applayer.rs
rust/src/enip/enip.rs
rust/src/ldap/ldap.rs
src/app-layer-smtp.c
enip.rs and ldap.rs are only in 8
Other conflict fixes while just taking the changes brought by this commit, not the ones which were done nearby in recent work