detect: add vlan.id keyword - v10#12374
Conversation
AkakiAlice
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
catenacyber
left a comment
catenacyber
left a comment
There was a problem hiding this comment.
Thanks Alice, nice work
CI : rerunning to get green CI with rebased SV 🤞
Code : cool
Commits segmentation : ok
Commit messages : nice
Git ID set : looks fine for me
CLA : you already contributed
Doc update : thanks for fixing the typos
Redmine ticket : ok
Rustfmt : ok
Tests : ok cool
Dependencies added: none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12374 +/- ##
==========================================
- Coverage 82.49% 82.48% -0.01%
==========================================
Files 912 914 +2
Lines 258083 258467 +384
==========================================
+ Hits 212897 213199 +302
- Misses 45186 45268 +82
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
minor rust style feedback
Think we're almost there, nice work :)
|
|
||
| static void DetectVlanIdFree(DetectEngineCtx *de_ctx, void *ptr) | ||
| { | ||
| rs_detect_vlan_id_free(ptr); |
There was a problem hiding this comment.
style: new code should use SCDetectVlanIdFree for public rust functions
There was a problem hiding this comment.
check the whole PR, essentially there should be no new rs_ functions
There was a problem hiding this comment.
Indeed
@jasonish @jufajardini do we have a better doc than https://docs.suricata.io/en/latest/devguide/codebase/code-style.html#function-names ?
|
Replaced by #12386 |
3 participants
Ticket: #1065
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/1065
Description:
Changes:
>=with>so vlan.id can match on values up to 4095: line 45-VLAN_MAX_LAYERSandVLAN_MAX_LAYERS - 1: line 560 - 4095: line 29du32withdu8: line 149SV_BRANCH=OISF/suricata-verify#2222
Previous PR: #12360