Applayer plugin 5053 v3.21#12383
Merged
victorjulien merged 5 commits intoOISF:masterfrom Jan 14, 2025
Merged
Conversation
Because some alprotos will remain static and defined as a constant, such as ALPROTO_UNKNOWN=0, or ALPROTO_FAILED. The regular already used protocols keep for now their static identifier such as ALPROTO_SNMP, but this could be made more dynamic in a later commit. ALPROTO_FAILED was used in comparison and these needed to change to use either ALPROTO_MAX or use standard function AppProtoIsValid
Ticket: 5053 The names are now dynamically registered at runtime. The AppProto alproto enum identifiers are still static for now. This is the final step before app-layer plugins.
Ticket: 5053
It needs app-layer registration for the names
catenacyber
requested review from
a team,
jasonish and
victorjulien
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12383 +/- ##
==========================================
- Coverage 82.46% 80.63% -1.84%
==========================================
Files 914 915 +1
Lines 258316 258440 +124
==========================================
- Hits 213030 208401 -4629
- Misses 45286 50039 +4753
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
Requested changes : add commit to add the template as an app-layer plugin |
|
WARNING:
Pipeline 24186 |
victorjulien
approved these changes
Jan 13, 2025
Member
Changed my mind on this. I'll merge this PR now to avoid future rebase cost. But please do the follow up PR with the template soon. |
Merged
Member
|
Merged in #12389, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5053
Describe changes:
#12372 with
Note that there is still #12307 to fix the limitation of probing parsers against 32 protocols (meaning any new app-layer like one in a plugin may be affected by this bug if it uses probing parsers for protocol detection)
After that, a next step can be to completely remove
ALPROTO_SNMPfrom C codeAnd also add template examples cf https://redmine.openinfosecfoundation.org/issues/4102