protodetect: finish probing parser sooner (backport7)#12463
Merged
victorjulien merged 1 commit intoOISF:main-7.0.xfrom Feb 11, 2025
Merged
Conversation
Ticket: 7495 We want to finish also if we tested all the expected protocols in mask, or if we tested even more. There can be one more protocol coming from pe0, which can be the protocol already found in the other direction. (cherry picked from commit b5094b0)
catenacyber
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12463 +/- ##
==============================================
- Coverage 83.13% 83.12% -0.02%
==============================================
Files 922 922
Lines 261187 261187
==============================================
- Hits 217147 217112 -35
- Misses 44040 44075 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24339 |
victorjulien
approved these changes
Feb 10, 2025
This was referenced Feb 10, 2025
Member
|
Merged in #12557, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7496
Describe changes:
(the other commit is not relevant because there is no smtp probing parser in 7)
SV_BRANCH=OISF/suricata-verify#2252