detect: add keywords for LDAPDN - v2#12545
Closed
AkakiAlice wants to merge 3 commits intoOISF:masterfrom
Closed
Conversation
ldap.request.dn matches on LDAPDN from request operations This keyword maps the following eve fields: ldap.request.bind_request.name ldap.request.add_request.entry ldap.request.search_request.base_object ldap.request.modify_request.object ldap.request.del_request.dn ldap.request.mod_dn_request.entry ldap.request.compare_request.entry It is a sticky buffer Supports prefiltering Ticket: OISF#7471
ldap.responses.dn matches on LDAPDN from responses operations This keyword maps the following eve fields: ldap.responses[].search_result_entry.base_object ldap.responses[].bind_response.matched_dn ldap.responses[].search_result_done.matched_dn ldap.responses[].modify_response.matched_dn ldap.responses[].add_response.matched_dn ldap.responses[].del_response.matched_dn ldap.responses[].mod_dn_response.matched_dn ldap.responses[].compare_response.matched_dn ldap.responses[].extended_response.matched_dn It is a sticky buffer Supports prefiltering Ticket: OISF#7471
AkakiAlice
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12545 +/- ##
==========================================
+ Coverage 80.68% 80.73% +0.04%
==========================================
Files 925 925
Lines 258914 259039 +125
==========================================
+ Hits 208914 209135 +221
+ Misses 50000 49904 -96
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
Looks good to me globally, @jasonish a better commit title for the nit prefix one ? |
Member
I've used
|
This was referenced Feb 11, 2025
Contributor
Author
|
Replaced by: #12556 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #7471
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues7471
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7471
Description:
ldap.request.dnandldap.responses.dnChanges:
Scprefix nits (replaceScwithSCfor detect register functions)ldap.responses.dnldap.request.dndocumentationSV_BRANCH=OISF/suricata-verify#2278
Previous PR: #12529