detect/csum: rm interaction btw stream setting/csum (main-7.0.x backport)#12548
Closed
jlucovsky wants to merge 2 commits intoOISF:main-7.0.xfrom
Closed
detect/csum: rm interaction btw stream setting/csum (main-7.0.x backport)#12548jlucovsky wants to merge 2 commits intoOISF:main-7.0.xfrom
jlucovsky wants to merge 2 commits intoOISF:main-7.0.xfrom
Conversation
Issue: 7467 Stream checksum validation no longer has a side effect of setting PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks. (cherry picked from commit 758da98)
Describe the change of behavior between the stream.checksum-validation setting and checksum-based rule keywords. (cherry picked from commit cfbf8fd)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12548 +/- ##
==============================================
+ Coverage 83.13% 83.23% +0.09%
==============================================
Files 922 922
Lines 261187 261183 -4
==============================================
+ Hits 217147 217385 +238
+ Misses 44040 43798 -242
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24671 |
victorjulien
approved these changes
Feb 10, 2025
This was referenced Feb 10, 2025
Member
|
Merged in #12557, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #12544
Backport of issue 7468
Stream checksum validation no longer has a side effect of setting PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7468
Describe changes:
Updates:
NB: Updated s-v test link: no functional changes in new pr.
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2277
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=