util: fix -Wshorten-64-to-32 warnings#12633
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12633 +/- ##
==========================================
- Coverage 80.77% 80.75% -0.02%
==========================================
Files 932 932
Lines 259286 259314 +28
==========================================
- Hits 209437 209413 -24
- Misses 49849 49901 +52
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24806 |
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
a nit inline, but can also address that in a follow up
| } | ||
| if (b > max) { | ||
| SCLogError("%s: upper bound (%ld) of cpu set is too high, only %d cpu(s)", name, b, | ||
| SCLogError("%s: upper bound (%d) of cpu set is too high, only %d cpu(s)", name, b, |
There was a problem hiding this comment.
%u now that b is uint32_t. Surprising no CI check rejected this.
There was a problem hiding this comment.
So, should I fix that in the next PR tackling other warnings ?
There was a problem hiding this comment.
yeah, staging branch with this PR is running
|
Merged in #12653, thanks! |
3 participants
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32warnings for some files : utilOne commit of #9840
#12624 CI fixed
Still to do afterwards :