detect/transform: Refactor setup/apply pattern#12640
Closed
jlucovsky wants to merge 1 commit intoOISF:masterfrom
Closed
detect/transform: Refactor setup/apply pattern#12640jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky wants to merge 1 commit intoOISF:masterfrom
Conversation
git grep -A 1 -w InspectionBufferSetup shows many cases of the following
call patterns:
- InspectionBufferSetup
- InspectionBufferApplyTransforms
Refactor the implementations of those functions into
InspectionBufferSetupAndApplyTransforms to reduce function call count.
Issue: 2290 (related to changed for this issue)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12640 +/- ##
==========================================
- Coverage 80.77% 80.75% -0.02%
==========================================
Files 932 932
Lines 259286 259258 -28
==========================================
- Hits 209437 209374 -63
- Misses 49849 49884 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24822 |
victorjulien
approved these changes
Feb 20, 2025
Merged
Member
|
Merged in #12653, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git grep -A 1 -w InspectionBufferSetup shows many cases of the following call patterns:
- InspectionBufferSetup
- InspectionBufferApplyTransforms
Refactor the implementations of those functions into InspectionBufferSetupAndApplyTransforms to reduce function call count.
Issue: 2290 (related to changes needed for this issue)
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=