rust: fix clippy 1.85 precedence warnings#12647
Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
Closed
rust: fix clippy 1.85 precedence warnings#12647catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
warning: operator precedence can trip the unwary
--> src/jsonbuilder.rs:781:36
|
781 | buf[offset] = HEX[(x >> 4 & 0xf) as usize];
| ^^^^^^^^^^^^ help: consider parenthesizing your expression: `(x >> 4) & 0xf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12647 +/- ##
==========================================
+ Coverage 80.76% 80.78% +0.01%
==========================================
Files 932 932
Lines 259381 259381
==========================================
+ Hits 209484 209535 +51
+ Misses 49897 49846 -51
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Feb 21, 2025
This was referenced Feb 21, 2025
Closed
Merged
Member
|
Merged in #12653, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, just clippy fixes
Describe changes: