Quic crypto reassembly 7556 backport7#12661
Merged
victorjulien merged 6 commits intoOISF:main-7.0.xfrom Feb 25, 2025
Merged
Conversation
Will alow to have decode_frames accept one additional parameter with past fragment data (cherry picked from commit ee04d66)
cf rfc9000 section 19.3. ACK Frames Ticket: 7556 (cherry picked from commit 68adc87)
Ticket: 7556 To do so, we need to add 2 buffers (one for each direction) to the QuicState structure, so that on parsing the second packet with hello/crypto fragment, we still have the data of the first hello/crypto fragment. Use a hardcoded limit so that these buffers cannot grow indefinitely and set an event when reaching the limit (cherry picked from commit f295cc0)
Ticket: 7556 (cherry picked from commit 6d8910d)
Ticket: 7556 Avoids failed_decrypt events when the first packet seen is not a Quic Initial packet (cherry picked from commit d61f36c)
Ticket: 7556 See RFC 9000 section 17.2.5.2 : After the client has received and processed an Initial or Retry packet from the server, it MUST discard any subsequent Retry packets that it receives. (cherry picked from commit 726de55)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12661 +/- ##
==============================================
+ Coverage 83.28% 83.30% +0.01%
==============================================
Files 922 922
Lines 261083 261171 +88
==============================================
+ Hits 217437 217556 +119
+ Misses 43646 43615 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24871 |
victorjulien
approved these changes
Feb 24, 2025
Member
|
Merged in #12663, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7557
Describe changes:
SV_BRANCH=OISF/suricata-verify#2316
Clean cherry-picks
Did not take the rustfmt commit