Conversation
|
NOTE: This PR may contain new authors. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14401 +/- ##
========================================
Coverage 84.15% 84.15%
========================================
Files 1014 1014
Lines 261991 262461 +470
========================================
+ Hits 220470 220875 +405
- Misses 41521 41586 +65
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
Looks pretty good overall.
Requests on the git side:
Ticket reference in the git commit.
Suggestion for the commit subject "os: support Solaris and Sparc"
| { "local7", LOG_LOCAL7 }, | ||
| { NULL, -1 } | ||
| }; | ||
| SCEnumCharMap sc_syslog_facility_map[] = { { "auth", LOG_AUTH }, { "authpriv", LOG_AUTHPRIV }, |
There was a problem hiding this comment.
would like to keep this manually formatted, so it would need to be wrapped in clang-format exclusion comments
|
|
||
| void SuricataPreInit(const char *progname) | ||
| { | ||
| /* |
There was a problem hiding this comment.
Would like to see this be a bit more compact, like in a helper func that is just called from here
|
Hi Victor,
On 12/2/25 17:08, Victor Julien wrote:
***@***.**** requested changes on this pull request.
Looks pretty good overall.
I am glad to read that!
Requests on the git side:
Ticket reference in the git commit.
Suggestion for the commit subject "os: support Solaris and Sparc"
------------------------------------------------------------------------
In src/util-syslog.c <https://github.com/OISF/suricata/
pull/14401#discussion_r2581847731>:
> - { "news", LOG_NEWS },
- { "security", LOG_AUTH },
- { "syslog", LOG_SYSLOG },
- { "user", LOG_USER },
- { "uucp", LOG_UUCP },
- { "local0", LOG_LOCAL0 },
- { "local1", LOG_LOCAL1 },
- { "local2", LOG_LOCAL2 },
- { "local3", LOG_LOCAL3 },
- { "local4", LOG_LOCAL4 },
- { "local5", LOG_LOCAL5 },
- { "local6", LOG_LOCAL6 },
- { "local7", LOG_LOCAL7 },
- { NULL, -1 }
-};
+SCEnumCharMap sc_syslog_facility_map[] = { { "auth", LOG_AUTH }, { "authpriv", LOG_AUTHPRIV },
would like to keep this manually formatted, so it would need to be
wrapped in clang-format exclusion comments
Will return it back. Where are the exlusion comments? Should I do it?
------------------------------------------------------------------------
In src/suricata.c <https://github.com/OISF/suricata/
pull/14401#discussion_r2581851088>:
> @@ -3000,6 +3000,14 @@ int InitGlobal(void)
void SuricataPreInit(const char *progname)
{
+ /*
Would like to see this be a bit more compact, like in a helper func that
is just called from here
That was requested in my previous attempt. I will update it.
Thank you,
m.
… —
Reply to this email directly, view it on GitHub <https://github.com/
OISF/suricata#14401#pullrequestreview-3530943983>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/
AEDH3U6ZFPQOG4C4ZS25EFD37W2QBAVCNFSM6AAAAACNZPACWKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMZQHE2DGOJYGM>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Before a code block add then after it add |
|
NOTE: This PR may contain new authors. |
|
Friendly ping @l1gi are you planning to finish this work ? |
|
Oh, sorry for delay. I have overlooked the fact there are changes requested. But now, I cannot find what kind of changes should I do. There is no link to any description. Could you help, please? |
|
Oh you force-pushed to fix #14401 (comment) and such, could you do a new rebased version of the PR ? see https://docs.suricata.io/en/latest/devguide/contributing/code-submission-process.html#pull-requests |
|
Okay, there is a new PR with changes merged into 1 commit: Thank you, |
3 participants
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7005
Describe changes:
https://lists.debian.org/debian-sparc/2012/01/msg00012.html
and:
https://www.winehq.org/pipermail/wine-patches/2011-February/098547.html.