output-json/output-json-flow: Geoip enrichment#14558
Closed
jayhardee9 wants to merge 2 commits intoOISF:mainfrom
Closed
output-json/output-json-flow: Geoip enrichment#14558jayhardee9 wants to merge 2 commits intoOISF:mainfrom
jayhardee9 wants to merge 2 commits intoOISF:mainfrom
Conversation
Add GeoIP enrichment to EVE JSON output. Ticket: 6999 Co-Authored-By: Fandi Gunawan <10239907+fandigunawan@users.noreply.github.com>
Add GeoIP enrichment to flow EVE logs.
|
NOTE: This PR may contain new authors. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14558 +/- ##
=======================================
Coverage 82.12% 82.13%
=======================================
Files 1014 1014
Lines 262461 262461
=======================================
+ Hits 215551 215571 +20
+ Misses 46910 46890 -20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
catenacyber
requested changes
Jan 4, 2026
Contributor
catenacyber
left a comment
There was a problem hiding this comment.
Thanks for your work.
Just a quick look and I see that CI is red
- because the changes to schema.json are not alphabetically ordered like
Current order: ['ip', 'geo'] Should be: ['geo', 'ip'] - because the C code is not formatted with clang-format ( see https://docs.suricata.io/en/latest/devguide/codebase/code-style.html#clang-format )
5 tasks
Author
|
Next iteration: #14567 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6999
Original author's PR: #10703
Describe changes:
geoip-enrichmentoption under eve-log configuration in suricata.yamljson-outputandjson-output-flowmodules.Eve output example with enrichment
{ "timestamp": "2021-05-27T03:37:44.575843+0700", "flow_id": 2130735805455113, "pcap_cnt": 15756, "event_type": "fileinfo", "geoip_src": { "ip": "192.236.155.230", "geo": { "continent_code": "NA", "country_iso_code": "US", "city_name": "Seattle", "country_name": "United States", "continent_name": "North America", "timezone": "America/Los_Angeles", "location": { "lat": 47.4902, "lon": -122.3004 } } }, "geoip_dst": {}, "src_ip": "192.236.155.230", "src_port": 80, "dest_ip": "10.5.26.4", "dest_port": 56042, "proto": "TCP", "pkt_src": "wire/pcap", "http": { "hostname": "192.236.155.230", "url": "/images/redbutton.png", "http_user_agent": "WinHTTP loader/1.0", "http_content_type": "Content-type: application/octet-stream", "http_method": "GET", "protocol": "HTTP/1.1", "status": 200, "length": 105556 }, "app_proto": "http", "fileinfo": { "filename": "/images/redbutton.png", "gaps": false, "state": "TRUNCATED", "stored": false, "size": 102400, "tx_id": 0 } }Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2838