Closed
Conversation
victorjulien
force-pushed
the
igmp/v2
branch
2 times, most recently
from
0848568 to
05c79d5
Compare
victorjulien
force-pushed
the
igmp/v2
branch
from
05c79d5 to
6b910f7
Compare
|
Information: QA ran without warnings. Pipeline = 29548 |
|
Information: QA ran without warnings. Pipeline = 29550 |
victorjulien
force-pushed
the
igmp/v2
branch
2 times, most recently
from
eee7049 to
938c454
Compare
victorjulien
commented
Feb 12, 2026
victorjulien
commented
Feb 12, 2026
| */ | ||
| void DetectIGMPTypeRegister(void) | ||
| { | ||
| sigmatch_table[DETECT_IGMP_TYPE].name = "igmp.type"; |
Member
Author
There was a problem hiding this comment.
I rejected the idea of overloading itype as it is documented to be about ICMP
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14794 +/- ##
==========================================
- Coverage 82.15% 82.14% -0.01%
==========================================
Files 1003 1007 +4
Lines 263691 263939 +248
==========================================
+ Hits 216626 216820 +194
- Misses 47065 47119 +54
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
force-pushed
the
igmp/v2
branch
from
938c454 to
a70fbc6
Compare
|
Information: QA ran without warnings. Pipeline = 29563 |
victorjulien
force-pushed
the
igmp/v2
branch
from
a70fbc6 to
79a5e93
Compare
jasonish
reviewed
Feb 12, 2026
jasonish
reviewed
Feb 12, 2026
|
Information: QA ran without warnings. Pipeline = 29568 |
victorjulien
force-pushed
the
igmp/v2
branch
from
79a5e93 to
e15deb0
Compare
Basic v1, v2 and v3 header validation. Ticket: OISF#8262.
So 'alert igmp ...' can work.
Add rule to decoder-events.rules to match on bad checksums.
Reordering of table and switch to match switch in parser.
RGMP is a dialect of IGMP that uses the same protocol structure, but with some different values for the fields. Detect this and log it differently.
victorjulien
force-pushed
the
igmp/v2
branch
from
e15deb0 to
483a501
Compare
|
Information: QA ran without warnings. Pipeline = 29569 |
|
Information: QA ran without warnings. Pipeline = 29573 |
Closed
Member
Author
|
Rebased in #14834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#2910
https://redmine.openinfosecfoundation.org/issues/8262
Adds decoder for IGMPv1, v2, v3, plus RGMP. Adds
igmp-csumkeyword,igmp.hdrsticky buffer andigmp.typekeyword. Misc other additions.