detect/proto: check ipproto enabled setting first#14802
Closed
detect/proto: check ipproto enabled setting first#14802
Conversation
If the key `app-layer.protocols.PROTO.enabled` is present, the protocol is enabled for all carrier protocols. This is not ideal. Only if the key `app-layer.protocols.PROTO.enabled` is missing, an attempt is made to look for a setting specific to the ipproto passed at the time of registration e.g. `app-layer.protocols.PROTO.udp.enabled`. By default, check for carrier proto specific setting. If it is not found, then fall back to the generic setting. Issue a warning in case an inconsistent combination of global and ipproto specific setting is found. Bug 8205
inashivb
requested review from
a team,
jufajardini and
victorjulien
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14802 +/- ##
==========================================
+ Coverage 82.15% 82.16% +0.01%
==========================================
Files 1003 1003
Lines 263674 263712 +38
==========================================
+ Hits 216610 216675 +65
+ Misses 47064 47037 -27
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 29570 |
jufajardini
reviewed
Feb 17, 2026
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
The docs and commit message look good to me, thanks :)
Member
|
Git message prefix suggests this is about the detection engine, but it's about app-layer. |
Member
Author
Changed in the following rev. Please check. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR: #14761
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8205
Changes since v7:
SV_BRANCH=OISF/suricata-verify#2912