Skip to content

Backports 80x/v1#14865

Closed
victorjulien wants to merge 8 commits intoOISF:main-8.0.xfrom
victorjulien:backports-80x/v1
Closed

Backports 80x/v1#14865
victorjulien wants to merge 8 commits intoOISF:main-8.0.xfrom
victorjulien:backports-80x/v1

Conversation

@victorjulien
Copy link
Member

@victorjulien victorjulien commented Feb 21, 2026 •
edited
Loading

victorjulien and others added 8 commits February 21, 2026 11:39
@victorjulien
npdi: fix null pointer deref in detect keywords
109f0a9 
Check for the existence of a flow before calling FlowGetStorageById() on it.

Ticket: OISF#8308.
(cherry picked from commit 278da4b)
@victorjulien
doc/userguide: explain isdataat absolute vs relative difference
1a6ce0e 
Ticket: OISF#8031.
(cherry picked from commit 7c5285e)
@victorjulien
doc/userguide: add example with non-zero offset for relative isdataat
7247f09 
Ticket: OISF#8031.
(cherry picked from commit 2d66253)
@victorjulien
doc/userguide: fix table showing example payload
f29be08 
Ticket: OISF#8031.
(cherry picked from commit a0cc534)
@victorjulien
doc/userguide: add link to differences-from-snort
21190b7 
Ticket: OISF#8031.
(cherry picked from commit 1246f1c)
@victorjulien
affinity: address coverity warning
2901c0c 
CID 1667318: (#1 of 1): Structurally dead code (UNREACHABLE)
unreachable: This code cannot be reached: hwloc_obj_t non_io_ancestor....

(cherry picked from commit b84ae80)
@victorjulien
af-xdp: add missing unlock in error path
29e192d 
CID 1638288: (#1 of 1): Missing unlock (LOCK)
4. missing_unlock: Returning without unlocking xsk_protect.queue_protect.

(cherry picked from commit e7c9be0)
@victorjulien
detect/iprep: mark as supported for firewall mode
cb36753 
Ticket: OISF#8285.
(cherry picked from commit db2e97a)
@victorjulien victorjulien requested review from a team and jufajardini as code owners February 21, 2026 11:00
@codecov
Copy link

codecov bot commented Feb 21, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.56%. Comparing base (592b294) to head (cb36753).
⚠️ Report is 14 commits behind head on main-8.0.x.

Additional details and impacted files 
@@              Coverage Diff               @@
##           main-8.0.x   #14865      +/-   ##
==============================================
- Coverage       83.58%   83.56%   -0.02%     
==============================================
  Files            1010     1010              
  Lines          266211   266212       +1     
==============================================
- Hits           222522   222470      -52     
- Misses          43689    43742      +53
Flag Coverage Δ
fuzzcorpus 64.00% <100.00%> (-0.02%) ⬇️
livemode 18.65% <100.00%> (+<0.01%) ⬆️
pcap 44.60% <100.00%> (-0.02%) ⬇️
suricata-verify 64.84% <100.00%> (-0.02%) ⬇️
unittests 58.87% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

suricata-qa commented Feb 21, 2026

Information: QA ran without warnings.

Pipeline = 29811

inashivb
inashivb approved these changes Feb 24, 2026
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien added this to the 8.0 milestone Feb 24, 2026
@victorjulien victorjulien mentioned this pull request Feb 24, 2026
Merged
@victorjulien
Copy link
Member Author

victorjulien commented Feb 24, 2026

Merged in #14892, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inashivb inashivb inashivb approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@victorjulien @suricata-qa @inashivb