Skip to content

next/1239/20260227/v1 #14915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
victorjulien wants to merge 2 commits into from
Closed

next/1239/20260227/v1 #14915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0928fd1
doc: fix dcerpc.opnum documentation
victorjulien Feb 27, 2026
e4eb55a
detect/transforms: update gunzip / zlib_deflate syntax
victorjulien Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/userguide/rules/dcerpc-keywords.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,18 @@ interface in a DCERPC header.
The format of the keyword::

dcerpc.opnum:<u16>;
dcerpc.opnum:[>,<,!,=]<u16>;
dcerpc.opnum:<u16>,<u16>,<u16>....;
dcerpc.opnum:<u16>-<u16>;

Examples::

dcerpc.opnum:15;
dcerpc.opnum:>10;
dcerpc.opnum:12,24,62,61;
dcerpc.opnum:12,18-24,5;
dcerpc.opnum:12-14,12,121,62-78;

.. note:: earlier versions of the documentation incorrectly stated that greater than, less than, etc. notation was supported. This may be added later, see #8179.

dcerpc.stub_data
----------------

Expand Down
12 changes: 6 additions & 6 deletions rust/src/detect/transforms/decompress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const ABSOLUTE_MAX_SIZE: u32 = 16 * 1024 * 1024;
fn decompress_parse_do(s: &str) -> Option<DetectTransformDecompressData> {
let mut max_size_parsed = None;
for p in s.split(',') {
let kv: Vec<&str> = p.split('=').collect();
let kv: Vec<&str> = p.split(' ').collect();
if kv.len() != 2 {
SCLogError!("Bad key value for decompress transform {}", p);
return None;
Expand Down Expand Up @@ -257,12 +257,12 @@ mod tests {
#[test]
fn test_decompress_parse() {
assert!(decompress_parse_do("keywithoutvalue").is_none());
assert!(decompress_parse_do("unknown=1").is_none());
assert!(decompress_parse_do("max-size=0").is_none());
assert!(decompress_parse_do("max-size=1,max-size=1").is_none());
assert!(decompress_parse_do("max-size=toto").is_none());
assert!(decompress_parse_do("unknown 1").is_none());
assert!(decompress_parse_do("max-size 0").is_none());
assert!(decompress_parse_do("max-size 1,max-size 1").is_none());
assert!(decompress_parse_do("max-size toto").is_none());
assert_eq!(
decompress_parse_do("max-size=1MiB"),
decompress_parse_do("max-size 1MiB"),
Some(DetectTransformDecompressData {
max_size: 1024 * 1024
})
Expand Down
Loading