Merged
Conversation
When mempool size was configured really low (<32), Suricata exhausted the mempool with the rx_burst call, which led to undefined behavior. The current fix ensures the burst size is at most the size of the mempool, if the mempool is smaller than BURST_SIZE macro. (cherry picked from commit 1d06103)
Check protocol before doing more expensive work. (cherry picked from commit 28ba93e)
(cherry picked from commit 29834e3)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #14993 +/- ##
==============================================
- Coverage 83.62% 83.62% -0.01%
==============================================
Files 1011 1011
Lines 266411 266417 +6
==============================================
- Hits 222791 222782 -9
- Misses 43620 43635 +15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lukashino
approved these changes
Mar 9, 2026
Contributor
lukashino
left a comment
lukashino
left a comment
There was a problem hiding this comment.
All looks good, nDPI conditions seems often redundant but ok. I mean this pattern:
If null:
Return;
Else if not null
Do something
|
Information: QA ran without warnings. Pipeline = 30101 |
Member
Author
|
Merged in #15000, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/issues/8312
and ndpi and dpdk backports