capture-bypass: fix worker timeout of bypassed flows v1#15331
Open
capture-bypass: fix worker timeout of bypassed flows v1#15331
Conversation
Forbid worker to timeout capture-bypassed flows, as it does not have the necessary components (BypassUpdate callback) to gather the necessary statistics from the flows to make this decisions. Leave the processing of bypass-capture flows only to FlowManager. Ticket: 8442
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15331 +/- ##
==========================================
- Coverage 82.64% 82.64% -0.01%
==========================================
Files 995 995
Lines 271075 271079 +4
==========================================
- Hits 224042 224040 -2
- Misses 47033 47039 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where Suricata does not check the statistics of bypassed flows that have been timed out by workers.
Proposed Solution
I propose to solve this issue by forbidding workers from timing out capture-bypassed flows and allowing only FlowManager to handle them.
Changes:
Links to ticket: 8442