eve: add rule generation source to alert record - v1#15335
eve: add rule generation source to alert record - v1#15335
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15335 +/- ##
==========================================
- Coverage 82.66% 82.64% -0.03%
==========================================
Files 995 995
Lines 271046 271048 +2
==========================================
- Hits 224069 224000 -69
- Misses 46977 47048 +71
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 31277 |
|
In other parts of the firewall logic I referred to the IDS/IPS rules as "td" (threat detection). I think it would make sense to use that here as well. |
When an alert is generated from firewall context, add an engine value of "fw", otherwise "td" (for threat detect). The engine field is only added when firewall mode is enabled. Ticket: OISF#8456
Makes sense. Updated to be |
| "fw", | ||
| "td" | ||
| ], | ||
| "description": "Engine that generated the alert in firewall mode: fw for firewall rules, td for threat detect rules." |
There was a problem hiding this comment.
| "description": "Engine that generated the alert in firewall mode: fw for firewall rules, td for threat detect rules." | |
| "description": "Engine that generated the alert in firewall mode: fw for firewall rules, td for threat detection rules." |
| the signature. | ||
|
|
||
| In firewall mode, the ``alert.engine`` field identifies which rule engine | ||
| generated the alert: ``fw`` for firewall rules and ``td`` for threat detect |
There was a problem hiding this comment.
| generated the alert: ``fw`` for firewall rules and ``td`` for threat detect | |
| generated the alert: ``fw`` for firewall rules and ``td`` for threat detection |
|
I didn't like I could imagine some post-processing engine in the future, or something... |
|
WARNING:
Pipeline = 31301 |
Ticket: https://redmine.openinfosecfoundation.org/issues/8456
SV_BRANCH=OISF/suricata-verify#3072
Draft to see how "alert.engine" feels... Examples: