Open
Conversation
Other parsers (SMB, POP3, ENIP) already raise a too_many_transactions event when a flow exceeds its per-flow transaction limit. FTP had the limit wired up through app-layer.protocols.ftp.max-tx but just dropped the excess transaction on the floor with a "FTP does not set events yet..." TODO, so no event was raised when the limit was reached. Add the FtpEventTooManyTransactions variant, a stock rule at sid 2232002, and raise the event from FTPTransactionCreate when the live-tx count goes past ftp_config_maxtx. Issue: 8489
The first version of the event set done=true on state->curr_tx and returned NULL when the limit hit. curr_tx is usually the active command just received — marking it done mid-request throws off response matching, and subsequent commands in the flow stop getting logged. SMB behavior is mirrored here: Walk the tx list, find the oldest tx that isn't done, mark it done and tag it with the event, then fall through and create the new tx so the flow parsing continues. One stale tx gets reaped per overflow so memory stays bounded. Issue: 8489
Add missing FTP configuration value to suricata.yaml.in showing the default value. Issue: 8489
Issue: 8489
|
NOTE: This PR may contain new authors. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15339 +/- ##
==========================================
- Coverage 82.66% 82.64% -0.03%
==========================================
Files 995 995
Lines 271046 271054 +8
==========================================
- Hits 224069 224009 -60
- Misses 46977 47045 +68
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 31294 |
victorjulien
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #15292
Raise an event when
app-layer.protocols.ftp.max-txis reached.Link to ticket: https://redmine.openinfosecfoundation.org/issues/8489
Describe changes:
Updates:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_BRANCH=OISF/suricata-verify#3041