dhcp parse continuation areas when option 52 overload is set#15340
Closed
dhcp parse continuation areas when option 52 overload is set#15340
Conversation
Per RFC 2132 the BOOTP sname and file fields can hold extra DHCP options when option 52 is present, but the parser ignored them. After parsing the main options we now look up option 52 and walk sname or file as additional option streams, appending what we find to the same options vector so the logger and detection keywords see overloaded values too.
|
NOTE: This PR may contain new authors. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15340 +/- ##
==========================================
- Coverage 82.66% 82.66% -0.01%
==========================================
Files 995 995
Lines 271046 271225 +179
==========================================
+ Hits 224069 224201 +132
- Misses 46977 47024 +47
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
requested changes
May 9, 2026
Member
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
Thanks for looking into this.
However, please make sure to follow our contribution guidelines:
https://docs.suricata.io/en/latest/devguide/contributing/index.html
This was referenced May 9, 2026
Author
|
Superseded by #15348 which addresses the contribution guideline feedback (subsystem prefixed commit, ticket reference, separate docs commit, branch v2). The verify side test is in OISF/suricata-verify#3074. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suricata only parsed DHCP options from the standard options area, so anything carried in the overloaded sname or file BOOTP fields was invisible to both EVE logging and detection. The reporter on issue 8538 attached a pcap where a server places dns server, router, and domain options entirely inside sname while the visible options look benign, and the current parser misses all of it. With this change we look at option 52 after parsing the main options and walk whichever continuation areas it points at, appending what we find to the same options vector that downstream code already iterates. New unit tests cover all three overload values, a malformed continuation case, and the actual pcap from the issue.