detect: guard rate filter callback registration, return bool on failure - #15586
Closed
kenifor wants to merge 2 commits into
Closed
detect: guard rate filter callback registration, return bool on failure#15586kenifor wants to merge 2 commits into
kenifor wants to merge 2 commits into
Conversation
added 2 commits
June 9, 2026 11:33
SCDetectEngineRegisterRateFilterCallback() dereferences the result of DetectEngineGetCurrent() unconditionally. Add a NULL guard with SCLogError and return false so callers can detect registration failure. Flagged by Svace and confirmed by gcc -fanalyzer. Ticket: 8560
Check DetectEngineEnabled() before registering, and warn if the registration call returns false.
victorjulien
approved these changes
Jun 9, 2026
jasonish
approved these changes
Jun 9, 2026
This was referenced Jun 10, 2026
Closed
Closed
Merged
Member
|
Merged in #15601, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #15558. Restored bool return; examples now check the return value and warn on failure.